Remove callbacks from job_queue_node #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JHolba
added
the
release-notes:skip
Codecov Report
@@ Coverage Diff @@
## main #6118 +/- ##
==========================================
- Coverage 82.48% 82.46% -0.03%
==========================================
Files 350 350
Lines 21442 21434 -8
Branches 834 834
==========================================
- Hits 17687 17675 -12
- Misses 3457 3461 +4
Partials 298 298
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JHolba
force-pushed
the
remove-fmodel-callbacks
branch
3 times, most recently
from
a865268 to
bc2f62f
Compare
berland
reviewed
Sep 20, 2023
| @@ -194,10 +194,12 @@ def run_done_callback(self) -> Optional[LoadStatus]: | |||
|
|
|||
| def run_timeout_callback(self) -> None: | |||
| if self.callback_timeout: | |||
| self.callback_timeout(*self.callback_arguments) | |||
| self.callback_timeout(self.run_arg.iens) | |||
|
|
|||
| def run_exit_callback(self) -> None: | |||
There was a problem hiding this comment.
should we avoid the string "callback" altogether?
There was a problem hiding this comment.
this is just a first pass. we will do more cleanup in later PRs
JHolba
force-pushed
the
remove-fmodel-callbacks
branch
2 times, most recently
from
f1ddbbb to
e2a30e1
Compare
Removed callbacks and split callback_arguments into run_arg and ensemble_config. Updated tests. Inlined exit callback into job_queue_node.
JHolba
force-pushed
the
remove-fmodel-callbacks
branch
from
e2a30e1 to
ef63ac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
job queue node now calls forward_model_ok directly instead of getting it as a callback.
Split callback_arguments into run_arg and ensemble_config.
Updated tests.
Inlined exit callback into job_queue_node.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist